Commander core fix hang#513
Merged
jonasmalacofilho merged 2 commits intoliquidctl:mainfrom Oct 4, 2022
Merged
Conversation
Contributor
|
In the documentation, instead of just changing it from 1024 bytes to 96 bytes. Can you mention that it is 1024 for firmware v1.x.x and 96 for v2.x.x. |
Meriemi-git
force-pushed
the
commander-core-fix-hang
branch
from
2764731 to
e29b906
Compare
Contributor
Author
|
You're right @ParkerMc i mention both values in documentation. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the _REPORT_LENGTH and _RESPONSE_LENGTH from 1024 to 96 to fix hang when loop over liquidctl status command according to @ParkerMc comment on issue #505
Fixes: #505
Checklist:
liquidctl.8Linux/Unix/Mac OS man pagedocs/*guide.mddevice guidesNew CLI flag?
extra/completions/New device?
extra/linux/71-liquidctl.rules(instructions in the file header)en)New driver?
docs/developer/protocol/