Skip to content

Add support for reading virtual temp sensors on Aquacomputer D5 Next#510

Merged
jonasmalacofilho merged 8 commits intoliquidctl:mainfrom
aleksamagicka:aqc-virt-sensors-d5next
Oct 16, 2022
Merged

Add support for reading virtual temp sensors on Aquacomputer D5 Next#510
jonasmalacofilho merged 8 commits intoliquidctl:mainfrom
aleksamagicka:aqc-virt-sensors-d5next

Conversation

@aleksamagicka
Copy link
Member

Add support for reading eight virtual temperature sensors on the Aquacomputer D5 Next. Virtual temperature sensors can be set by the user, but that is not yet reverse engineered.


Checklist:

  • Adhere to the development process
  • Conform to the style guide
  • Verify that the changes work as expected on real hardware
  • Add automated tests cases
  • Verify that all (other) automated tests (still) pass
  • Update the README and other applicable documentation pages
  • Update the liquidctl.8 Linux/Unix/Mac OS man page
  • Update or add applicable docs/*guide.md device guides
  • Submit relevant data, scripts or dissectors to https://github.com/liquidctl/collected-device-data

New CLI flag?

  • Adjust the completion scripts in extra/completions/

New device?

  • Regenerate extra/linux/71-liquidctl.rules (instructions in the file header)
  • Add entry to the README's supported device list with applicable notes (at least en)

New driver?

  • Document the protocol in docs/developer/protocol/

Copy link
Member

@jonasmalacofilho jonasmalacofilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Enqueued for the next cycle, as we're now in the pre-release freeze.

@jonasmalacofilho
Copy link
Member

Thanks!

@aleksamagicka
Copy link
Member Author

Thanks, marking the date two weeks from now for new PRs.

@jonasmalacofilho
Copy link
Member

Thanks again. And sorry, I forgot that this freeze will be slightly longer: the release is scheduled for 11 October.

@aleksamagicka
Copy link
Member Author

No problem! I'll work on upstreaming parts of the driver in the meantime.

@jonasmalacofilho jonasmalacofilho added this to the liquidctl 1.12.0 milestone Oct 12, 2022
@jonasmalacofilho jonasmalacofilho merged commit 758daaa into liquidctl:main Oct 16, 2022
@jonasmalacofilho
Copy link
Member

Merged, thanks!

@aleksamagicka aleksamagicka deleted the aqc-virt-sensors-d5next branch October 17, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants