Skip to content

Add Octo support to aquacomputer driver#492

Merged
jonasmalacofilho merged 9 commits intoliquidctl:mainfrom
aleksamagicka:aqc-octo
Aug 11, 2022
Merged

Add Octo support to aquacomputer driver#492
jonasmalacofilho merged 9 commits intoliquidctl:mainfrom
aleksamagicka:aqc-octo

Conversation

@aleksamagicka
Copy link
Member

@aleksamagicka aleksamagicka commented Aug 11, 2022 •
edited
Loading

Add support for reading Octo temperature sensors and groups of fan-related sensor info to the aquacomputer driver.

Related: #438

Checklist:

  • Adhere to the development process
  • Conform to the style guide
  • Verify that the changes work as expected on real hardware
  • Add automated tests cases
  • Verify that all (other) automated tests (still) pass
  • Update the README and other applicable documentation pages
  • Update the liquidctl.8 Linux/Unix/Mac OS man page
  • Update or add applicable docs/*guide.md device guides
  • Submit relevant data, scripts or dissectors to https://github.com/liquidctl/collected-device-data

New CLI flag?

  • Adjust the completion scripts in extra/completions/

New device?

  • Regenerate extra/linux/71-liquidctl.rules (instructions in the file header)
  • Add entry to the README's supported device list with applicable notes (at least en)

New driver?

  • Document the protocol in docs/developer/protocol/

@aleksamagicka aleksamagicka marked this pull request as ready for review August 11, 2022 13:55
jonasmalacofilho added a commit that referenced this pull request Aug 11, 2022
@jonasmalacofilho
udev: always use utf-8 when writing into a rules file
35c8fe5 
This should prevent further unwanted changes to the encoding of
71-liquidctl.rules (see 63f685b).

@aleksamagicka, please regenerate the rules file in PR #492 with this
change.

Related: 63f685b
@aleksamagicka
Copy link
Member Author

aleksamagicka commented Aug 11, 2022 •
edited
Loading

71-liquidctl.rules should now be proper UTF-8 in this PR. I regenerated it in Win10 originally, had no idea Powershell was doing its own thing, sorry. Did it from a proper Linux install now.

@jonasmalacofilho
Copy link
Member

jonasmalacofilho commented Aug 11, 2022

71-liquidctl.rules should now be proper UTF-8 in this PR. I regenerated it in Win10 originally, had no idea Powershell was doing its own thing, sorry. Did it from a proper Linux install now.

Well, the generator script was also a bit careless and simply assumed an UTF-8 locale.

That's fixed. And IIRC a normal git configuration on Windows already takes care of the line endings.

@jonasmalacofilho jonasmalacofilho merged commit 72968d5 into liquidctl:main Aug 11, 2022
@jonasmalacofilho
Copy link
Member

jonasmalacofilho commented Aug 11, 2022

Merged, thanks!

@aleksamagicka aleksamagicka deleted the aqc-octo branch August 11, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasmalacofilho jonasmalacofilho jonasmalacofilho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aleksamagicka @jonasmalacofilho