Add Farbwerk 360 support to aquacomputer driver#491
Merged
jonasmalacofilho merged 11 commits intoliquidctl:mainfrom Aug 9, 2022
Merged
Add Farbwerk 360 support to aquacomputer driver#491jonasmalacofilho merged 11 commits intoliquidctl:mainfrom
jonasmalacofilho merged 11 commits intoliquidctl:mainfrom
Conversation
liquidctl/driver/aquacomputer.py
Outdated
Comment on lines
+51
to
+54
| """Support for hwmon: aquacomputer_d5next driver | ||
| - D5 Next watercooling pymp: sensors - 5.15+ | ||
| - Farbwerk 360: sensors - 5.18+ | ||
| """ |
Member
There was a problem hiding this comment.
I think it's better to move this note to the module docstring, or to a simple comment. It's currently hard for non-Linux users to parse, and as the entire class docstring, it also suggests that this driver is only about hwmon support.
Member
Author
There was a problem hiding this comment.
Thanks, moved it to the module docstring.
| mockD5NextDevice.set_fixed_speed("pump", 84) | ||
|
|
||
|
|
||
| def test_kraken_speed_profiles_not_supported(mockD5NextDevice): |
Member
There was a problem hiding this comment.
Oh, I totally missed this before, ops : )
Member
|
Merged, thanks! |
jonasmalacofilho
added a commit
that referenced
this pull request
Aug 11, 2022
PR #491 unexpectedly changed the encoding the of 71-liquidctl.rules: $ file extra/linux/71-liquidctl.rules extra/linux/71-liquidctl.rules: Unicode text, UTF-16, little-endian text, with CRLF line terminators Regenerate the file and change it back to UTF-8: extra/linux/71-liquidctl.rules: Unicode text, UTF-8 text Fixes: #491 Fixes: 747af54 Cc: @aleksamagicka
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #482, this PR adds support and tests for reading temperature sensors of the Aquacomputer Farbwerk 360 RGB controller.
Related: #438
Checklist:
liquidctl.8Linux/Unix/Mac OS man pagedocs/*guide.mddevice guidesNew CLI flag?
extra/completions/New device?
extra/linux/71-liquidctl.rules(instructions in the file header)en)New driver?
docs/developer/protocol/