HydroPro: Fix duplicate use of second alert temp#484
Merged
jonasmalacofilho merged 1 commit intoliquidctl:mainfrom Jul 24, 2022
Merged
HydroPro: Fix duplicate use of second alert temp#484jonasmalacofilho merged 1 commit intoliquidctl:mainfrom
jonasmalacofilho merged 1 commit intoliquidctl:mainfrom
Conversation
Somewhere between the initial proposal[1] and the final inclusion[2] of this feature, this seems to have been changed to use the second alert temperature twice. This is a bug that results in what I can only describe as the colour getting "stuck" at the interpolated halfway-point between color2 and color3 when temperature rises over 40 degrees. Tested with my h100i Pro RGB, using all three temperatures results in the expected behaviour of interpolation between color1 and color2 between 30 and 40 degrees, and interpolation between color2 and color3 between 40 and 50 degrees. [1] <https://github.com/liquidctl/liquidctl/pull/234/files#diff-6e83d451ee55e2e559f9aa43783fe2574adddb8edaf9252aca4b476b5f0821b5R212> [2] <https://github.com/liquidctl/liquidctl/pull/264/files#diff-6e83d451ee55e2e559f9aa43783fe2574adddb8edaf9252aca4b476b5f0821b5R186>
Member
|
Thanks! Yeap, and I'm the one that messed up: b86d6c5f2fb8a. I'm going to merge without waiting on feedback from #461 because, regardless of that, this fixes what's clearly a mistake. (But I also expect this to fix #461). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhere between the initial proposal[1] and the final inclusion[2] of this feature, this seems to have been changed to use the second alert temperature twice.
This is a bug that results in what I can only describe as the colour getting "stuck" at the interpolated halfway-point between color2 and color3 when temperature rises over 40 degrees.
Tested with my h100i Pro RGB, using all three temperatures results in the expected behaviour of interpolation between color1 and color2 between 30 and 40 degrees, and interpolation between color2 and color3 between 40 and 50 degrees.
[1] https://github.com/liquidctl/liquidctl/pull/234/files#diff-6e83d451ee55e2e559f9aa43783fe2574adddb8edaf9252aca4b476b5f0821b5R212
[2] https://github.com/liquidctl/liquidctl/pull/264/files#diff-6e83d451ee55e2e559f9aa43783fe2574adddb8edaf9252aca4b476b5f0821b5R186
Fixes: No issue filed, possibly #461
Related: #137, #234, #264
Checklist:
All unchecked items were imo non-applicable.
liquidctl.8Linux/Unix/Mac OS man pagedocs/*guide.mddevice guidesNothing new was added, so remaining checklist items removed.