BTW, @jonasmalacofilho liquidctl could use a more declarative approach to parsing HID reports, like kernel drivers: Python's ctypes can even handle non-native byte order. See https://github.com/amezin/amdgpu-pptable/

(It's a suggestion to Jonas, @thecosmonad you don't have to do anything)

I won't add support for H1 fan controller to the kernel driver myself, since this change can't be trivially converted to the kernel driver, and I don't have the corresponding hardware to verify it.

Hi @amezin, if I'll have some spare time to look at the kernel dirver sources I'll see if I can figure it out, that's probably the best thing as I do have the hardware indeed.

@jonasmalacofilho have you managed to take a look at the pull? What do you think? I was wondering whether this could end up in a v1.9.2 or not?

@thecosmonad,

@jonasmalacofilho have you managed to take a look at the pull? What do you think?

Sorry, not yet had the time to do it.

I was wondering whether this could end up in a v1.9.2 or not?

Since it's support for a new device and it's not just enabling a VID/PID, it needs to go into 1.10.0 (we use semantic versioning). That's scheduled for early July.

@amezin,

BTW, @jonasmalacofilho liquidctl could use a more declarative approach to parsing HID reports, like kernel drivers: Python's ctypes can even handle non-native byte order. See https://github.com/amezin/amdgpu-pptable/

Acknowledged, thanks.

Hi @jonasmalacofilho,

Don't worry, I'm glad you've provided so many hints and help!

I think it should be fine now... Hopefully 🤞🏻

I mean, apparently the case hasn't blown up. Yet.

LGTM, merged.

Thanks again!

Glad to hear that.

Thank you too for the massive work that went into this project, contributing has been a super fun experience!

As a new device (even on the market), if something goes wrong with other H1 V2 owners don't heistate pinging me, I'll see if I can help.