fix: jshint works on Windows

nfischer · nfischer · commit 03c30c6a1f43 · 2016-01-18T21:36:41.000-08:00
run-tests.js previously relied on shell wildcard expansion, and did not specify
full paths. This uses common.expand to handle globbing internally, and specifies
the full path, so jshint can find all the files.
diff --git a/scripts/generate-docs.js b/scripts/generate-docs.js
@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+/* globals cd, echo, grep, sed */
 require('../global');
 
 echo('Appending docs to README.md');
diff --git a/scripts/run-tests.js b/scripts/run-tests.js
@@ -1,22 +1,27 @@
 #!/usr/bin/env node
+/* globals cd, echo, exec, exit, ls, pwd, test */
 require('../global');
-
-var path = require('path');
+var common = require('../src/common');
 
 var failed = false;
 
 //
 // Lint
 //
-JSHINT_BIN = './node_modules/jshint/bin/jshint';
+var JSHINT_BIN = 'node_modules/jshint/bin/jshint';
 cd(__dirname + '/..');
 
 if (!test('-f', JSHINT_BIN)) {
   echo('JSHint not found. Run `npm install` in the root dir first.');
   exit(1);
 }
 
-if (exec(JSHINT_BIN + ' *.js test/*.js').code !== 0) {
+var jsfiles = common.expand([pwd() + '/*.js',
+                             pwd() + '/scripts/*.js',
+                             // pwd() + '/src/*.js',
+                             pwd() + '/test/*.js'
+                            ]).join(' ');
+if (exec('node ' + pwd() + '/' + JSHINT_BIN + ' ' + jsfiles).code !== 0) {
   failed = true;
   echo('*** JSHINT FAILED! (return code != 0)');
   echo();

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`#!/usr/bin/env node`
	`2`	`+/* globals cd, echo, grep, sed */`
`2`	`3`	`require('../global');`
`3`	`4`
`4`	`5`	`echo('Appending docs to README.md');`