Revert PublicDefinitions back to Definitions

slartibaartfast · slartibaartfast · commit c2b53730ece9 · 2018-05-14T10:02:00.000-04:00
diff --git a/Source/UnrealEnginePython/UnrealEnginePython.Build.cs b/Source/UnrealEnginePython/UnrealEnginePython.Build.cs
@@ -217,7 +217,7 @@ public UnrealEnginePython(TargetInfo Target)
             string libPath = GetMacPythonLibFile(pythonHome);
             PublicLibraryPaths.Add(Path.GetDirectoryName(libPath));
             PublicDelayLoadDLLs.Add(libPath);
-            PublicDefinitions.Add(string.Format("UNREAL_ENGINE_PYTHON_ON_MAC"));
+            Definitions.Add(string.Format("UNREAL_ENGINE_PYTHON_ON_MAC"));
         }
         else if (Target.Platform == UnrealTargetPlatform.Linux)
         {
@@ -242,13 +242,13 @@ public UnrealEnginePython(TargetInfo Target)
                 PublicIncludePaths.Add(items[0]);
                 PublicAdditionalLibraries.Add(items[1]);
             }
-            PublicDefinitions.Add(string.Format("UNREAL_ENGINE_PYTHON_ON_LINUX"));
+            Definitions.Add(string.Format("UNREAL_ENGINE_PYTHON_ON_LINUX"));
         }
 
         string enableThreads = System.Environment.GetEnvironmentVariable("UEP_ENABLE_THREADS");
         if (!string.IsNullOrEmpty(enableThreads))
         {
-            PublicDefinitions.Add("UEPY_THREADING");
+            Definitions.Add("UEPY_THREADING");
             System.Console.WriteLine("*** Enabled Python Threads support ***");
         }
 

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ public UnrealEnginePython(TargetInfo Target)`
`217`	`217`	`string libPath = GetMacPythonLibFile(pythonHome);`
`218`	`218`	`PublicLibraryPaths.Add(Path.GetDirectoryName(libPath));`
`219`	`219`	`PublicDelayLoadDLLs.Add(libPath);`
`220`		`- PublicDefinitions.Add(string.Format("UNREAL_ENGINE_PYTHON_ON_MAC"));`
	`220`	`+ Definitions.Add(string.Format("UNREAL_ENGINE_PYTHON_ON_MAC"));`
`221`	`221`	`}`
`222`	`222`	`else if (Target.Platform == UnrealTargetPlatform.Linux)`
`223`	`223`	`{`
`@@ -242,13 +242,13 @@ public UnrealEnginePython(TargetInfo Target)`
`242`	`242`	`PublicIncludePaths.Add(items[0]);`
`243`	`243`	`PublicAdditionalLibraries.Add(items[1]);`
`244`	`244`	`}`
`245`		`- PublicDefinitions.Add(string.Format("UNREAL_ENGINE_PYTHON_ON_LINUX"));`
	`245`	`+ Definitions.Add(string.Format("UNREAL_ENGINE_PYTHON_ON_LINUX"));`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`string enableThreads = System.Environment.GetEnvironmentVariable("UEP_ENABLE_THREADS");`
`249`	`249`	`if (!string.IsNullOrEmpty(enableThreads))`
`250`	`250`	`{`
`251`		`- PublicDefinitions.Add("UEPY_THREADING");`
	`251`	`+ Definitions.Add("UEPY_THREADING");`
`252`	`252`	`System.Console.WriteLine("* Enabled Python Threads support *");`
`253`	`253`	`}`
`254`	`254`