Added Alternate for MergePartsOfSpeech called BuildDictionary, and WordScraper#9
Closed
drventure wants to merge 2 commits intoligos:masterfrom
Closed
Added Alternate for MergePartsOfSpeech called BuildDictionary, and WordScraper#9drventure wants to merge 2 commits intoligos:masterfrom
drventure wants to merge 2 commits intoligos:masterfrom
Conversation
Owner
|
Thanks for your work Darin. Now I've just got to find time to review. |
Author
|
Hi Murray
I know how that goes. Certainly no hurry. I got things patched and working fine for what I was looking for but if it can be useful to you or others, all the better!
Darin
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Murray Grant <[email protected]>
Sent: Friday, November 13, 2020 9:03:20 PM
To: ligos/readablepassphrasegenerator <[email protected]>
Cc: Darin Higgins <[email protected]>; Author <[email protected]>
Subject: Re: [ligos/readablepassphrasegenerator] Added Alternate for MergePartsOfSpeech called BuildDictionary, and WordScraper (#9)
Thanks for your work Darin. Now I've just got to find time to review.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#9 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAOMXBV7DW4IHCWB5MPXGSLSPXXPRANCNFSM4TTURMOQ>.
|
Owner
|
Incorporated changes into https://github.com/ligos/readablepassphrasegenerator/tree/github-pullrequest9-scraper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added 2 new projects to the solution.
BuildDictionary is a duplicate of MergePartsOfSpeech, but with some added capability, mainly that it enumerates all the XML files in the current dir and uses them all to build the dict bs using a hardwired list.
It also embeds all the base level xml files as resources.
WordScraper is what I used to pull AI generated words off the thisworddoesnotexist.com website. it then breaks them up into custom word files based on parts of speech.
Finally, I embedded a late version of Keepass.exe in the project for reference purposes because otherwise, the reference ends up pointing to some arbitrary place on your HD.