Add splice cleanup invariants#4699
Conversation
|
👋 Thanks for assigning @wpaulino as a reviewer! |
|
The diff is unchanged from my prior review pass, and I've now confirmed the error strings ( My previously-flagged issue (tx_abort branch missing the One additional observation not covered before, worth noting: No new issues found beyond the prior review. Summary of standing findings (already posted, still unaddressed):
Cross-cutting notes (not blocking):
|
After tx_abort or SpliceNegotiationFailed, probe splice_channel to ensure stale queued or active negotiation state does not remain. This lets the chanmon consistency harness catch recoverability gaps where an aborted or failed splice still blocks a fresh attempt.
54f80b2 to
bef13fe
Compare
|
Claude's cross-cutting notes might be worth addressing in a follow up #4699 (comment) |
After tx_abort or SpliceNegotiationFailed, probe splice_channel to ensure stale queued or active negotiation state does not remain.
This lets the chanmon consistency harness catch recoverability gaps where an aborted or failed splice still blocks a fresh attempt.