[Fixbug]: Repository object reference count increase abnormal#328
Closed
shinningstar wants to merge 1 commit intolibgit2:masterfrom
Closed
[Fixbug]: Repository object reference count increase abnormal#328shinningstar wants to merge 1 commit intolibgit2:masterfrom
shinningstar wants to merge 1 commit intolibgit2:masterfrom
Conversation
…g 'remotes' attribute each time.
Contributor
|
LGTM :-) |
Member
|
While this does fix the issue with the current code, I wonder if we shouldn't get rid of the |
Member
|
yes that would be better, actually I think it would read something like: so we can refactor the code with |
Contributor
|
Please review #332 , thanks. |
Member
|
okey merged #332 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #326, Repository object's reference count will be increased abnormally by it's remotes getter function. That is because 'py_args' does not release which hold 1 reference to repository.
This issue stem from my requirement to dealloc repository object for purpose of releasing file descriptor resource occupied by it. When I construct a new repository object, I found that the old one won't be deconstructed since it's reference count can't decrease to zero.