ssh: fix known_hosts leak in _git_ssh_setup_conn #6599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven9724
force-pushed
the
fix-ssh-memleak
branch
from
09ad7a0 to
66e5a58
Compare
steven9724
force-pushed
the
fix-ssh-memleak
branch
from
66e5a58 to
1a14641
Compare
Member
|
Thanks for the fix! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In _git_ssh_setup_conn, known_hosts is allocated by _git_ssh_session_create. However, known_hosts is only cleaned up in the case of error.
This moves the cleanup code for known_hosts so that its run in the error an success case.
Fixes #6598