Skip to content

Use #!/bin/bash for script with bash-specific commands #6581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ethomson merged 2 commits into from
Nov 20, 2023
Merged

Use #!/bin/bash for script with bash-specific commands #6581

ethomson merged 2 commits into from
Nov 20, 2023

Conversation

@roehling
Copy link
Contributor

@roehling roehling commented Jun 19, 2023

The test/Resources/push.sh calls pushd/popd, which is not a POSIX shell feature but a Bash extension.

@roehling
Use #!/bin/bash for script with bash-specific commands
1e2ea79 
The test/Resources/push.sh calls pushd/popd, which is not a POSIX
shell feature but a Bash extension.
ethomson
ethomson reviewed Jul 14, 2023
View reviewed changes
@ethomson
Copy link
Member

ethomson commented Nov 20, 2023

Thanks for the fix!

@ethomson ethomson merged commit 95adbde into libgit2:main Nov 20, 2023
@ethomson ethomson added the build label Dec 14, 2023
@branchv branchv mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethomson ethomson ethomson left review comments

+1 more reviewer

@neithernut neithernut neithernut left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roehling @ethomson @neithernut