Chose a better name for the parameter to text

charasyn · lava · commit e49f4f7cce9e · 2018-12-05T12:18:14.000+01:00
diff --git a/matplotlibcpp.h b/matplotlibcpp.h
@@ -797,12 +797,12 @@ bool stem(const std::vector<Numeric>& y, const std::string& format = "")
 }
 
 template<typename Numeric>
-void text(Numeric x, Numeric y, const std::string& format = "")
+void text(Numeric x, Numeric y, const std::string& s = "")
 {
     PyObject* args = PyTuple_New(3);
     PyTuple_SetItem(args, 0, PyFloat_FromDouble(x));
     PyTuple_SetItem(args, 1, PyFloat_FromDouble(y));
-    PyTuple_SetItem(args, 2, PyString_FromString(format.c_str()));
+    PyTuple_SetItem(args, 2, PyString_FromString(s.c_str()));
 
     PyObject* res = PyObject_CallObject(detail::_interpreter::get().s_python_function_text, args);
     if(!res) throw std::runtime_error("Call to text() failed.");

Original file line number	Diff line number	Diff line change
`@@ -797,12 +797,12 @@ bool stem(const std::vector<Numeric>& y, const std::string& format = "")`
`797`	`797`	`}`
`798`	`798`
`799`	`799`	`template<typename Numeric>`
`800`		`-void text(Numeric x, Numeric y, const std::string& format = "")`
	`800`	`+void text(Numeric x, Numeric y, const std::string& s = "")`
`801`	`801`	`{`
`802`	`802`	`PyObject* args = PyTuple_New(3);`
`803`	`803`	`PyTuple_SetItem(args, 0, PyFloat_FromDouble(x));`
`804`	`804`	`PyTuple_SetItem(args, 1, PyFloat_FromDouble(y));`
`805`		`- PyTuple_SetItem(args, 2, PyString_FromString(format.c_str()));`
	`805`	`+ PyTuple_SetItem(args, 2, PyString_FromString(s.c_str()));`
`806`	`806`
`807`	`807`	`PyObject* res = PyObject_CallObject(detail::_interpreter::get().s_python_function_text, args);`
`808`	`808`	`if(!res) throw std::runtime_error("Call to text() failed.");`