ENH use variadic templates args in scatter and figure#166
Open
Bidibulke wants to merge 9 commits intolava:masterfrom
Open
ENH use variadic templates args in scatter and figure#166Bidibulke wants to merge 9 commits intolava:masterfrom
Bidibulke wants to merge 9 commits intolava:masterfrom
Conversation
TST * adding some unit tests using Catch2 framework * 6 test cases with 91 assertions. * normally there is a test for each function in matplotlibcpp.h * `class Plot` is not tested MISC According to numpy documentation: * BLD change related to building and installing (examples, module, …) * ENH enhancement * TST addition or modification of tests * ...
commit 9047863bb0c1a34bc6473c2dadee720073db631e Author: Claire Guilbaud <[email protected]> Date: Thu Mar 26 15:46:34 2020 +0100 @enh figure with variadic template args commit a8a3dd018c14a5e5c98b084f566865ba936c4fec Author: Claire Guilbaud <[email protected]> Date: Thu Mar 26 14:55:36 2020 +0100 @enh close commit 6440609657de0f47b6fd4c1a8c213704f2810a4f Author: Claire Guilbaud <[email protected]> Date: Thu Mar 26 13:41:18 2020 +0100 @enh generic form for scatter
Bidibulke
force-pushed
the
merge/var_temp_args
branch
from
9ae729d to
06425a4
Compare
commit b9bd9d7488d0109f58d195c3964631635614e5e1 Author: Claire Guilbaud <[email protected]> Date: Fri May 29 15:29:00 2020 +0200 ENH quiver extension / streamplot added
ENH quiver * adding ``quiver(x, y, u, w, color)`` * adding support of variadic template args in ``quiver`` ENH streamplot * adding ``streamplot(x, y, u, w)`` with variadic template args * adding ``analyze_key_value`` for ``vector<vector<double>>`` TST * new C++ Catch2 tests for new functionalities
Author
|
I added streamplot function (still with variadic template args). I also extended quiver to accept a vector color as 5th arguments (in the generic form), and new tests for those functionalities. |
Interpreter has to be initialized otherwise PyLong_FromLong returns a not null object, but null inside ...
ENH: * New functions: `plot_surface`, `imshow`, `stem` * Added new example * Tests with Catch2 updated MAINT: * replace __function by detail::function for intern functions like for imshow BUG FIX PyLong_FromLong in analyse_keywords * Interpreter has to be initialized otherwise PyLong_FromLong returns a not null object, but null inside ...
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to avoid adding other declaration function for the same functionnality with other arguments, I had the possibility to pass extra-arguments in a tuple of variadic templates.
The kwargs of matplotlib functions are accessible using a tuple of pair (string, T). T can be :
The syntax is not heavy, and if other types are needed, just implement a function such as
Some examples:
streamplotscatter