Skip to content

Commit 52a014d

Browse files
clydinalexeagle
authored andcommitted
fix(@angular-devkit/core): ignore undefined targets when adding a workspace project
1 parent a3811a7 commit 52a014d

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

etc/api/angular_devkit/core/src/_golden-api.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -773,7 +773,7 @@ export declare class ProjectDefinitionCollection extends DefinitionCollection<Pr
773773
root: string;
774774
sourceRoot?: string;
775775
prefix?: string;
776-
targets?: Record<string, TargetDefinition>;
776+
targets?: Record<string, TargetDefinition | undefined>;
777777
[key: string]: unknown;
778778
}): this;
779779
set(name: string, value: ProjectDefinition): this;

packages/angular_devkit/core/src/workspace/definitions.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ export class ProjectDefinitionCollection extends DefinitionCollection<ProjectDef
146146
root: string,
147147
sourceRoot?: string,
148148
prefix?: string,
149-
targets?: Record<string, TargetDefinition>,
149+
targets?: Record<string, TargetDefinition | undefined>,
150150
[key: string]: unknown,
151151
},
152152
): this {
@@ -165,7 +165,9 @@ export class ProjectDefinitionCollection extends DefinitionCollection<ProjectDef
165165

166166
if (definition.targets) {
167167
for (const [name, target] of Object.entries(definition.targets)) {
168-
project.targets.set(name, target);
168+
if (target) {
169+
project.targets.set(name, target);
170+
}
169171
}
170172
}
171173

0 commit comments

Comments
 (0)