test: review, fix, and rename "flakey" tests#148
Merged
Conversation
added 2 commits
January 25, 2024 11:02
Signed-off-by: Timothy MacDonald <[email protected]>
"Flakey" is not the correct spelling of the word and it conflicts with the pytest "flaky" tag which is a different thing. The intent here is to avoid confusion. Signed-off-by: Timothy MacDonald <[email protected]>
dmurray-lacework
approved these changes
Jan 25, 2024
Valid fieldKey values changed Signed-off-by: Timothy MacDonald <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
There are a number of tests put into the "flakey" group because they fail intermittently. Fix the ones that can be fixed and rename the "flakey" group to "quarantine" to avoid confusion with the "flaky" tag provided by pytest which is a a similar but not identical thing.
Testing:
Ran all the tests successfully multiple times except for the single quarantined.
Since these are intermittent though I will watch nightly tests for a while to ensure they are truly fixed before I turn on slack alerting again.
Issue:
https://lacework.atlassian.net/browse/GROW-2664