test: fix race condition with delete tests#139
Merged
Conversation
Tests are randomly failing across all of the modules. Disabled alerting for now. Also sorted some tests by refactoring the order in which they run. Signed-off-by: Timothy MacDonald <[email protected]>
tmac1973
force-pushed
the
tmacdonald/GROW-2297/fix-integration-tests
branch
from
bcdd0c9 to
5f74348
Compare
Signed-off-by: Timothy MacDonald <[email protected]>
tmac1973
force-pushed
the
tmacdonald/GROW-2297/fix-integration-tests
branch
from
6224fd5 to
65d0cc0
Compare
afiune
approved these changes
Dec 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Seeing random failures due to race condition in which "get_by_guid" test would still return deleted object after delete call, causing subsequent "get details" call to fail with 404.
Details:
Add pytest-order and ensure that delete test always runs last for any given endpoint
Disable slack alerting until tests are working for sure.
Issue:
https://lacework.atlassian.net/browse/GROW-2297