Skip to content

test: fix slack alerting and mark some tests as flakey#137

Merged
tmac1973 merged 5 commits intomainfrom
tmacdonald/GROW-2297/fix-integration-tests
Dec 27, 2023
Merged

test: fix slack alerting and mark some tests as flakey#137
tmac1973 merged 5 commits intomainfrom
tmacdonald/GROW-2297/fix-integration-tests

Conversation

@tmac1973
Copy link
Contributor

@tmac1973 tmac1973 commented Dec 27, 2023

Summary:

Slack alert did not include link to workflow run.

ResourceGroupV2 beta flag is turned on in techally test environment causing one of those tests to fail. Marking that test as "flakey" for now. Opening separate issue to fix

Some AlertChannel test are failing randomly with a 404. Marking "flakey" for now and opening separate issue to investigate.

Issue:

https://lacework.atlassian.net/browse/GROW-2297

Timothy MacDonald added 2 commits December 27, 2023 11:47
Temporarily mark the get_by_guid test as flakey due to changes in the API

Signed-off-by: Timothy MacDonald <[email protected]>
@tmac1973 tmac1973 requested a review from a team as a code owner December 27, 2023 17:57
Timothy MacDonald added 2 commits December 27, 2023 12:08
This test is failing randomly with a 404 error.
Marking flaky for now until the issue can be resolved.

Signed-off-by: Timothy MacDonald <[email protected]>
These randomly fail with a 404 error. More investigation needed.

Signed-off-by: Timothy MacDonald <[email protected]>
@tmac1973 tmac1973 changed the title test: fix slack alerting and mark resource group test flakey test: fix slack alerting and mark some tests as flakey Dec 27, 2023
Randomly produces 404 errors. Needs investigation

Signed-off-by: Timothy MacDonald <[email protected]>
@tmac1973 tmac1973 merged commit 12edf70 into main Dec 27, 2023
@tmac1973 tmac1973 deleted the tmacdonald/GROW-2297/fix-integration-tests branch December 27, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments