Code refactoring, to make the library more Pythonic and nicer to use#32
Closed
rshk wants to merge 19 commits intoahupp:masterfrom
Closed
Code refactoring, to make the library more Pythonic and nicer to use#32rshk wants to merge 19 commits intoahupp:masterfrom
rshk wants to merge 19 commits intoahupp:masterfrom
Conversation
This is still missing tests, I'm going to rewrite then tomorrow.. :)
Owner
|
Hi, sorry for sitting on this for so long. The property based interface is nice. However, the major problem we have in the realm of python/magic interfaces right now is having too many of them, primarily the overlap between the experimental one in the file distribution and this one. Given that I suspect most users just want to get a mimetype and go on their way, I don't believe the new interface is a large enough improvement to justify adding more fragmentation. I did walk through your diffs to look for anything else that could be pulled, and grabbed the setup.py change to add a test suite. Another submitter added the travis.yml file so we're set with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have a look at the code and let me know what do you think..
It looks way cleaner to me this way (and of course tests are up & running on 2.6, 2.7, 3.1, 3.2 and 3.3), while keeping retro-compatibility (hopefully, anyways old tests are running on new library).