Replace urlEqualTo with urlPathEqualTo in WireMock test stubs#4401
Merged
k8s-ci-robot merged 2 commits intomasterfrom Nov 18, 2025
Merged
Replace urlEqualTo with urlPathEqualTo in WireMock test stubs#4401k8s-ci-robot merged 2 commits intomasterfrom
k8s-ci-robot merged 2 commits intomasterfrom
Conversation
… used Co-authored-by: brendandburns <[email protected]>
Copilot
AI
changed the title
[WIP] Substitute urlPathEqualTo for urlEqualTo where appropriate
Replace urlEqualTo with urlPathEqualTo in WireMock test stubs
Nov 17, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, Copilot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WireMock test stubs were using
urlEqualTo(full URL + query params) whenurlPathEqualTo(path only) was appropriate. This matters when URLs don't contain query parameters but tests need to allow them to be added dynamically.Changes
urlEqualTowithurlPathEqualToin stub definitions where URLs lack query parametersurlEqualToin 1 case where query parameters are explicitly part of the URL matchExample
Files Modified
util/src/test/java/io/kubernetes/client/util/generic/GenericKubernetesApiForCoreApiTest.java(15 changes)util/src/test/java/io/kubernetes/client/util/generic/GenericKubernetesApiTest.java(9 changes)util/src/test/java/io/kubernetes/client/util/generic/GenericKubernetesGetApiTest.java(4 changes)spring/src/test/java/io/kubernetes/client/spring/extended/manifests/KubernetesManifestTest.java(2 changes)util/src/test/java/io/kubernetes/client/util/generic/KubernetesApiResponseTest.java(2 changes)examples/examples-release-latest/src/test/java/io/kubernetes/client/examples/ExampleTest.java(1 change)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.