Skip to content

add static link library target#27

Closed
keroxp wants to merge 3 commits intokishikawakatsumi:masterfrom
keroxp:master
Closed

add static link library target#27
keroxp wants to merge 3 commits intokishikawakatsumi:masterfrom
keroxp:master

Conversation

@keroxp
Copy link
Copy Markdown

@keroxp keroxp commented Mar 10, 2014

hi, I added SLL target to the workspace.

This configuration contains a lot of configurations as follows:

  • libJavaScriptBridge, which is SSL for iOS, has been added.
  • Tests scheme has been deleted.
  • JavaScriptBride target has been renamed into JavaScriptBridgeApp
  • JavaScriptBridgeTests has been linked with JavaScriptBridgeApp and libJavaScriptBridge as a primary test target.
  • removed almost all of compilied source for JavaScriptBridge in Build Phases, because of adding dependency of libJavaScriptBridge to it.
  • .travis.yml also has been changed.

I have tested all targets in workspace in local environment, with success.
So, Please consider to merge this pull-request for external use this repository.

thank you :)

keroxp added 2 commits March 10, 2014 13:36
- with renaming target of JavaScriptBridge -> JavaScriptBridgeApp
@kishikawakatsumi
Copy link
Copy Markdown
Owner

Please do not include unnecessary files such as .gitkeep to the project or target.
.gitkeep などのビルドに不要なファイルがプロジェクトやターゲットに含まれてしまっているので、含めないようにしてください。

2014-03-10 15 00 00

2014-03-10 15 00 08

Please keep original project structures as possible, because of this project has so many auto-generated files.
It is important to keep clearly project structures.
できるだけ、元のプロジェクトの構成を保つようにしてください。
自動生成されたファイルが大量にあるなど、特殊な構成のプロジェクトなので、ひと目でわかりやすい構成を保つことは重要です。
ただ、今回の変更はターゲットの追加などを含むのである程度はしかたないですが、明らかに順序が変わっていたりするものは直してください。

2014-03-10 15 12 44

@keroxp
Copy link
Copy Markdown
Author

keroxp commented Mar 10, 2014

@kishikawakatsumi thank you for your consideration. I did restore project's structures to the original as possible as I can
返信ありがとうございます。ひとまず出来る限りの復元を試みました。

@keroxp
Copy link
Copy Markdown
Author

keroxp commented Mar 10, 2014

I also changed Copy Headers phase in libJavaScriptBridge, following public/private separation written in podsepc. libJavaScriptBridgeでコピーするヘッダについては、podspecの通りに分けました。

@kishikawakatsumi
Copy link
Copy Markdown
Owner

ありがとうございます。明日から休暇なのでまた週末に見ますね。

@keroxp
Copy link
Copy Markdown
Author

keroxp commented Mar 11, 2014

よろしくお願いしますm(_ _)m

@kishikawakatsumi
Copy link
Copy Markdown
Owner

遅くなってごめんなさい。7.1の対応がかなり大きなものになるので、この変更についてはその後で出し直してもらったほうがいいかなと思います。

せっかく時間を使っていただいたのにすみません。

@keroxp keroxp closed this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants