Update to ODPI-C 4.0.1 and add test to ensure that the offset is returned

anthony-tuininga · anthony-tuininga · commit 10e5c258fe9f · 2020-06-26T10:33:13.000-06:00
correctly when a parse error is encountered.
diff --git a/doc/src/release_notes.rst b/doc/src/release_notes.rst
@@ -10,9 +10,9 @@ Version 8.0 (June 2020)
 
 #)  Dropped support for Python 2. For those still requiring Python 2, see
     :ref:`python2`.
-#)  Updated embedded ODPI-C to `version 4.0
+#)  Updated embedded ODPI-C to `version 4.0.1
     <https://oracle.github.io/odpi/doc/releasenotes.html#
-    version-4-0-june-25-2020>`__.
+    version-4-0-1-june-26-2020>`__.
 #)  Reworked type management to clarify and simplify code
 
     - Added :ref:`constants <dbtypes>` for all database types. The database
diff --git a/odpi b/odpi
@@ -1 +1 @@
-Subproject commit adf293fefc6f030d25b453baed292e1b1b5cb6fa
+Subproject commit 9b8206d2d6baf8add270038c6b425c1ef450d309
diff --git a/test/Error.py b/test/Error.py
@@ -16,16 +16,21 @@
 
 class TestCase(TestEnv.BaseTestCase):
 
+    def testParseError(self):
+        "test parse error returns offset correctly"
+        with self.assertRaises(cx_Oracle.Error) as cm:
+            self.cursor.execute("begin t_Missing := 5; end;")
+        errorObj, = cm.exception.args
+        self.assertEqual(errorObj.offset, 6)
+
     def testPickleError(self):
         "test picking/unpickling an error object"
-        errorObj = None
-        try:
+        with self.assertRaises(cx_Oracle.Error) as cm:
             self.cursor.execute("""
                     begin
                         raise_application_error(-20101, 'Test!');
                     end;""")
-        except cx_Oracle.Error as e:
-            errorObj, = e.args
+        errorObj, = cm.exception.args
         self.assertEqual(type(errorObj), cx_Oracle._Error)
         self.assertTrue("Test!" in errorObj.message)
         self.assertEqual(errorObj.code, 20101)
@@ -42,4 +47,3 @@ def testPickleError(self):
 
 if __name__ == "__main__":
     TestEnv.RunTestCases()
-
