deps: switch to modernc.org/sqlite for pure go builds#221
Open
AlexCuse wants to merge 3 commits intokeratin:mainfrom
Open
deps: switch to modernc.org/sqlite for pure go builds#221AlexCuse wants to merge 3 commits intokeratin:mainfrom
AlexCuse wants to merge 3 commits intokeratin:mainfrom
Conversation
Contributor
Author
|
Note the actual builds are not yet changed to remove CGO dependency. Validated using the docker local build and an additional make target for tests since -race requires running with CGO. |
AlexCuse
changed the title
AlexCuse
commented
Apr 5, 2024
Contributor
Author
AlexCuse
left a comment
AlexCuse
left a comment
There was a problem hiding this comment.
This was interesting to look at. Not sure how much easier it makes ARM builds if at all. But I was impressed with the SQLite implementation in general.
|
|
||
| func NewDB(env string) (*sqlx.DB, error) { | ||
| // https://github.com/mattn/go-sqlite3/issues/274#issuecomment-232942571 | ||
| // https://modernc.org/sqlite/issues/274#issuecomment-232942571 |
Contributor
Author
There was a problem hiding this comment.
Pretty sure this ain't right 😅
| github.com/joho/godotenv v1.2.0 | ||
| github.com/lib/pq v1.10.0 | ||
| github.com/mattn/go-sqlite3 v1.6.0 | ||
| github.com/mattn/go-sqlite3 v1.14.18 // indirect |
Contributor
Author
There was a problem hiding this comment.
Imported for tests per https://pkg.go.dev/modernc.org/sqlite#section-readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For evaluation with #129
Another pure go sqlite client that may be worth considering is https://github.com/glebarez/go-sqlite