Conversation
There was a problem hiding this comment.
Pull request overview
Updates the reusable integrations workflow to default to a specific integrations repo ref (fix/postgres-trust-auth) when callers do not provide an explicit integration-ref.
Changes:
- Changed the default value of the
integration-refworkflow input frommaintofix/postgres-trust-auth.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| required: false | ||
| type: string | ||
| default: 'main' # Use main branch if nothing is sent** | ||
| default: 'fix/postgres-trust-auth' # Use main branch if nothing is sent** |
There was a problem hiding this comment.
The inline comment is now incorrect (it still says to use the main branch) and it also contains stray trailing **. Please update/remove the comment so it accurately reflects the default ref being used.
| default: 'fix/postgres-trust-auth' # Use main branch if nothing is sent** | |
| default: 'fix/postgres-trust-auth' # Default integrations ref if not provided |
| required: false | ||
| type: string | ||
| default: 'main' # Use main branch if nothing is sent** | ||
| default: 'fix/postgres-trust-auth' # Use main branch if nothing is sent** |
There was a problem hiding this comment.
Setting the default integration-ref to a non-default/feature branch (fix/postgres-trust-auth) can make the workflow fragile (e.g., callers that rely on defaults will break once the branch is renamed/deleted). Consider keeping the default as a stable ref (e.g., main or a tag/commit SHA) and overriding the input only in the specific caller(s) that need this branch.
| default: 'fix/postgres-trust-auth' # Use main branch if nothing is sent** | |
| default: 'main' # Use main branch if nothing is sent** |
| @@ -6,7 +6,7 @@ on: | |||
| description: 'The git ref (branch, tag, or commit) of the integrations repo to use.' | |||
| required: false | |||
| type: string | |||
| default: 'main' # Use main branch if nothing is sent** | |||
| default: 'fix/postgres-trust-auth' # Use main branch if nothing is sent** | |||
There was a problem hiding this comment.
PR description refers to an input named integrations_repo_ref, but this workflow defines the input as integration-ref. Please align the PR description (or rename the input if that was the intent) to avoid confusion for workflow callers.
Signed-off-by: gouravkrosx <[email protected]>
Signed-off-by: gouravkrosx <[email protected]>
Signed-off-by: gouravkrosx <[email protected]>
This pull request updates the default branch used for the integrations repository in the GitHub Actions workflow configuration. Instead of using the
mainbranch by default, the workflow will now use thefix/postgres-trust-authbranch unless another branch is specified.Workflow configuration update:
defaultvalue for theintegrations_repo_refinput in.github/workflows/prepare_and_run_integrations.ymlfrommaintofix/postgres-trust-authto ensure the workflow uses the correct branch for integration tests.