Fix FP uninitMemberVarPrivate with anonymous union (danmar#3927)

chrchr-github · web-flow · commit e0830693c3ea · 2022-03-23T07:35:41.000+01:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -170,7 +170,7 @@ void CheckClass::constructors()
                 if (var.isPrivate() && !var.isStatic() &&
                     (!var.isClass() || (var.type() && var.type()->needInitialization == Type::NeedInitialization::True))) {
                     ++needInit;
-                    if (!var.isInit() && !var.hasDefault())
+                    if (!var.isInit() && !var.hasDefault() && var.nameToken()->scope() == scope) // don't warn for anonymous union members
                         uninitVars.emplace_back(&var);
                     else
                         ++haveInit;
diff --git a/test/testconstructors.cpp b/test/testconstructors.cpp
@@ -3187,8 +3187,8 @@ class TestConstructors : public TestFixture {
         ASSERT_EQUALS("", errout.str());
     }
 
-    void uninitVarUnion1() { // ticket #3196
-        check("class Fred\n"
+    void uninitVarUnion1() {
+        check("class Fred\n" // ticket #3196
               "{\n"
               "private:\n"
               "    union { int a; int b; };\n"
@@ -3197,6 +3197,12 @@ class TestConstructors : public TestFixture {
               "    { a = 0; }\n"
               "};");
         ASSERT_EQUALS("", errout.str());
+
+        check("class Fred {\n"
+              "private:\n"
+              "    union { int a{}; int b; };\n"
+              "};");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void uninitVarUnion2() {
