The threadsafety.py addon now flags MT-Unsafe symbols and functions. (cppcheck-opensource#5086)

andrew-aitchison · web-flow · commit 072752887682 · 2023-06-08T14:46:09.000+02:00
diff --git a/.github/workflows/CI-unixish.yml b/.github/workflows/CI-unixish.yml
@@ -378,8 +378,8 @@ jobs:
       # TODO: move to scriptcheck.yml so these are tested with all Python versions?
       - name: Test addons
         run: |
-          ./cppcheck --addon=threadsafety addons/test/threadsafety
-          ./cppcheck --addon=threadsafety --std=c++03 addons/test/threadsafety
+          ./cppcheck --error-exitcode=1 --inline-suppr --addon=threadsafety addons/test/threadsafety
+          ./cppcheck --error-exitcode=1 --inline-suppr --addon=threadsafety --std=c++03 addons/test/threadsafety
           ./cppcheck --addon=misra --enable=style --inline-suppr --enable=information --error-exitcode=1 addons/test/misra/misra-ctu-*-test.c
           pushd addons/test
           # We'll force C89 standard to enable an additional verification for
diff --git a/addons/test/threadsafety/MT-Unsafe.cpp b/addons/test/threadsafety/MT-Unsafe.cpp
@@ -0,0 +1,67 @@
+/*
+ * Cppcheck - A tool for static C/C++ code analysis
+ * Copyright (C) 2023 Cppcheck team.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/*
+ * This does not match the standard cppchek test code,
+ * because I haven't figured that out yet.
+ * This code does compile and run, and does demonstrate
+ * the issues that the threadsafety.py addon is supposed to find.
+ * It does not use threads !
+ */
+
+#include <stdio.h>
+#include <time.h>
+#include <string.h>
+
+void threadsafety_static()
+{
+    // cppcheck-suppress threadsafety-threadsafety
+    static unsigned int nCount = 0;
+
+    nCount++;
+    printf("%d\n", nCount);
+}
+
+void threadsafety_call()
+{
+    time_t now = time(nullptr);
+    // cppcheck-suppress threadsafety-unsafe-call
+    printf("%s\n", ctime(&now));
+}
+
+// cppcheck --addon=threadsafety
+// should *not* find any problems with this function.
+void threadsafety_safecall()
+{
+    char haystack[] = "alphabet";
+    char needle[] = "Alph";
+    char* found = strcasestr(haystack, needle);
+    printf("%s %sin %s\n", needle, found ? "" : "not ", haystack);
+}
+
+int main() {
+    threadsafety_static();
+    
+    threadsafety_call();
+
+    threadsafety_safecall();
+
+    threadsafety_static();
+
+    return 0;
+}
diff --git a/addons/test/threadsafety/local_static.cpp b/addons/test/threadsafety/local_static.cpp
@@ -2,5 +2,6 @@ struct Dummy {
  int x;
 };
 void func() {
-  static Dummy dummy;
+    // cppcheck-suppress threadsafety-threadsafety
+    static Dummy dummy;
 }
diff --git a/addons/test/threadsafety/local_static_const.cpp b/addons/test/threadsafety/local_static_const.cpp
@@ -2,5 +2,6 @@ struct Dummy {
  int x;
 };
 void func() {
+  // cppcheck-suppress threadsafety-threadsafety-const
   static const Dummy dummy;
 }
diff --git a/addons/threadsafety.py b/addons/threadsafety.py
diff --git a/tools/MT-Unsafe.py b/tools/MT-Unsafe.py

Original file line number	Diff line number	Diff line change
`@@ -2,5 +2,6 @@ struct Dummy {`
`2`	`2`	`int x;`
`3`	`3`	`};`
`4`	`4`	`void func() {`
`5`		`- static Dummy dummy;`
	`5`	`+ // cppcheck-suppress threadsafety-threadsafety`
	`6`	`+ static Dummy dummy;`
`6`	`7`	`}`