Add code examples for missing array dimension

soir20 · soir20 · commit 3db679fffeec · 2021-06-08T12:49:01.000-04:00
diff --git a/java/src/processing/mode/java/pdex/JavaHint.java b/java/src/processing/mode/java/pdex/JavaHint.java
@@ -25,6 +25,8 @@ public static List<EditorHints.Hint> fromIProblem(IProblem compilerError, ASTNod
         );
 
         switch (compilerError.getID()) {
+            case IProblem.MustDefineEitherDimensionExpressionsOrInitializer:
+                return getArrDimHints(problemNode);
             case IProblem.TypeMismatch:
                 String providedType = truncateClass(problemArguments[0]);
                 String requiredType = truncateClass(problemArguments[1]);
@@ -34,6 +36,25 @@ public static List<EditorHints.Hint> fromIProblem(IProblem compilerError, ASTNod
         return Collections.emptyList();
     }
 
+    private static List<EditorHints.Hint> getArrDimHints(ASTNode problemNode) {
+        List<EditorHints.Hint> hints = new ArrayList<>();
+
+        String arrType = problemNode.toString();
+        String arrName = ((VariableDeclarationFragment) problemNode.getParent().getParent().getParent())
+                .getName().toString();
+        String problemTitle = "You have not given the array  a certain size.";
+
+        // Suggest adding array dimension
+        JavaHint addDim = new JavaHint(problemTitle,
+                "You have not given the array a certain size."
+        );
+        addDim.addBadCode(arrType + "[] " + arrName + " = new " + arrType + "[];");
+        addDim.addGoodCode(arrType + "[] " + arrName + " = new " + arrType + "[5];");
+        hints.add(addDim);
+
+        return hints;
+    }
+
     private static List<EditorHints.Hint> getTypeMismatchHints(String providedType, String requiredType,
                                                                ASTNode problemNode) {
         List<EditorHints.Hint> hints = new ArrayList<>();
@@ -42,6 +63,7 @@ private static List<EditorHints.Hint> getTypeMismatchHints(String providedType,
         String problemTitle = "You are trying to use the " + getVarDescription(requiredType)
                 + " " + varName + " as a " + getVarDescription(providedType) + ".";
 
+        // Suggest changing variable declaration
         JavaHint changeVarDec = new JavaHint(problemTitle,
                 "You might need to change the variable declaration of "
                         + varName + " to type " + providedType + "."
@@ -50,6 +72,7 @@ private static List<EditorHints.Hint> getTypeMismatchHints(String providedType,
         changeVarDec.addGoodCode(getDemoDeclaration(providedType, varName));
         hints.add(changeVarDec);
 
+        // Suggest changing variable value
         JavaHint changeValue = new JavaHint(problemTitle,
                 "You might need to change the value of "
                         + varName + " to a " + requiredType + "."
@@ -58,6 +81,7 @@ private static List<EditorHints.Hint> getTypeMismatchHints(String providedType,
         changeValue.addGoodCode(getDemoDeclaration(requiredType, varName));
         hints.add(changeValue);
 
+        // Suggest changing return type
         JavaHint changeReturnType = new JavaHint(problemTitle,
                 "You might need to change the method's return type to "
                        + providedType + "."
