Implement document.createComment() in client/dom and related files #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the missing
document.createComment()DOM API method in the JSAR runtime. Previously, the method was declared in the JavaScript bindings but returnedundefinedinstead of creating Comment nodes.Changes Made
Core Implementation
createComment(const std::string &data)method that creates Comment nodes with the specified text content and proper owner document referenceCreateCommentmethod to properly validate arguments, create Comment nodes, and return them to JavaScript with appropriate error handlingDOM Integration
HTMLDocument::SerializeFragment()to output proper HTML comment format (<!--content-->)appendChild(),insertBefore(), etc.Testing
API Usage
The implementation follows the MDN specification and DOM Standard, ensuring Comment nodes have correct properties (
nodeType: COMMENT_NODE,nodeName: "#comment") and behavior.Fixes #232.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
registry.npmmirror.comnpm ci(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.