Skip to content

Deprecate all public String constructors #9489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 1 commit into from
Jun 11, 2026
+7 −0
Merged

Deprecate all public String constructors #9489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/main/java/org/jruby/RubyString.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,14 +435,17 @@ public void verifyAsciiCompatible() {
if (!getEncoding().isAsciiCompatible()) throw getRuntime().newEncodingCompatibilityError("ASCII incompatible encoding: " + getEncoding());
}

@Deprecated(since = "10.0.6.0")
public RubyString(Ruby runtime, RubyClass rubyClass) {
this(runtime, rubyClass, ByteList.NULL_ARRAY);
}

@Deprecated(since = "10.0.6.0")
public RubyString(Ruby runtime, RubyClass rubyClass, CharSequence value) {
this(runtime, rubyClass, value, UTF8);
}

@Deprecated(since = "10.0.6.0")
public RubyString(Ruby runtime, RubyClass rubyClass, CharSequence value, Encoding enc) {
super(runtime, rubyClass);
assert value != null;
Expand All @@ -467,24 +470,28 @@ private RubyString(Ruby runtime, RubyClass rubyClass, String value, Encoding enc
this.value = encodeBytelist(value, enc);
}

@Deprecated(since = "10.0.6.0")
public RubyString(Ruby runtime, RubyClass rubyClass, byte[] value) {
super(runtime, rubyClass);
assert value != null;
this.value = new ByteList(value);
}

@Deprecated(since = "10.0.6.0")
public RubyString(Ruby runtime, RubyClass rubyClass, ByteList value) {
super(runtime, rubyClass);
assert value != null;
this.value = value;
}

@Deprecated(since = "10.0.6.0")
public RubyString(Ruby runtime, RubyClass rubyClass, ByteList value, boolean objectSpace) {
super(runtime, rubyClass, objectSpace);
assert value != null;
this.value = value;
}

@Deprecated(since = "10.0.6.0")
public RubyString(Ruby runtime, RubyClass rubyClass, ByteList value, Encoding encoding, boolean objectSpace) {
this(runtime, rubyClass, value, objectSpace);
value.setEncoding(encoding);
Expand Down
Loading