Replace now-deprecated wait_timeout#9300
Merged
Merged
Conversation
BlockingTask has been deprecated since 9.0.0.0, but the SleepTask subclass and its consumer RubyThread.wait_timeout were left undeprecated. In order to provide a migration path, this patch introduces a new blessed version of wait_timeout that no longer uses the deprecated BlockingTask. See ruby-concurrency/concurrent-ruby#1100. concurrent-ruby will eventually need to migrate to the blessed API, but until JRuby 10.0 is EOL we must continue to support the older method.
headius
force-pushed
the
replace_wait_timeout
branch
from
1effde8 to
24f8918
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlockingTask has been deprecated since 9.0.0.0, but the SleepTask subclass and its consumer RubyThread.wait_timeout were left undeprecated. In order to provide a migration path, this patch introduces a new blessed version of wait_timeout that no longer uses the deprecated BlockingTask.
See ruby-concurrency/concurrent-ruby#1100.
concurrent-ruby will eventually need to migrate to the blessed API, but until JRuby 10.0 is EOL we must continue to support the older method.