Skip to content

Use live counts for event hook stats #9277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 1 commit into from
Mar 1, 2026
+1 −9
Merged

Use live counts for event hook stats #9277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions core/src/main/java/org/jruby/runtime/TraceEventManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ public class TraceEventManager {
private final Ruby runtime;
private volatile EventHook[] eventHooks = EMPTY_HOOKS;
private boolean hasEventHooks;
private volatile int added;
private volatile int deleted;
private final CallTraceFuncHook callTraceFuncHook = new CallTraceFuncHook(null);

private final MutableCallSite callTrace = new MutableCallSite(TRACE_OFF);
Expand Down Expand Up @@ -86,7 +84,6 @@ public synchronized void addEventHook(ThreadContext context, EventHook hook) {
eventHooks = newHooks;

hasEventHooks = true;
added++;

enableTraceSites(hook);
}
Expand Down Expand Up @@ -118,8 +115,6 @@ public synchronized void removeEventHook(EventHook hook) {

disableTraceSites(hook);
}
added--;
deleted++;
}

private void enableTraceSites(EventHook hook) {
Expand Down Expand Up @@ -183,9 +178,6 @@ public void removeAllCallEventHooksFor(ThreadContext context) {

disableTraceSites();
}

added -= size - newHooks.length;
deleted += size - newHooks.length;
}

public void callEventHooks(ThreadContext context, RubyEvent event, String file, int line, String name, IRubyObject type) {
Expand Down Expand Up @@ -221,7 +213,7 @@ public boolean hasEventHooks() {
}

public int[] eventHookStats() {
return new int[] {added, deleted};
return new int[] {eventHooks.length, 0};
}

public static class CallTraceFuncHook extends EventHook {
Expand Down
Loading