Cleanup recursion guards#9273
Closed
headius wants to merge 2 commits into
Closed
Conversation
headius
force-pushed
the
exec_recursive_cleanup
branch
from
575941c to
7d4ade3
Compare
This matches CRuby (non-outer recursion check).
headius
force-pushed
the
exec_recursive_cleanup
branch
from
7d4ade3 to
13e2aae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on recursive Object inspect output for Ruby 4.0 I realized many places we are using "outer" recursion checking where CRuby passes false for "outer". This builds off that discovery to clean up other places where we do recursion checking differently than CRuby.