Make refine method of Module private#9213
Merged
Merged
Conversation
Same as MRI
Member
|
Yup, good catch. We probably should rework "module" visibility to do this by default, since it's almost always the expected behavior. |
Member
|
Related issue where we made the default visibility for some methods "private" if unspecified: #8210 |
Member
|
The sequel and concurrent-ruby jobs seem to be hanging while bundling... I'm not sure what's up with that but it's unlikely to be related to your change. |
headius
approved these changes
Feb 4, 2026
Member
|
Nevermind what I said about module methods; this is just a normal method that should have had PRIVATE visibility. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MRI refine method is defined as private. But in JRuby it is public leading to inconsistency between the implementations.