Skip to content

Cache both hash forms for FString #9143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 1 commit into from
Dec 30, 2025
Merged

Cache both hash forms for FString #9143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion core/src/main/java/org/jruby/RubyString.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1256,14 +1256,16 @@ protected void mutateChilledString() {
*/
public static class FString extends RubyString {
private IRubyObject converted;
private final long hash;
private final int hash;
private final RubyFixnum fixHash;

protected FString(Ruby runtime, ByteList value, int cr) {
super(runtime, runtime.getString(), value, cr, false);

this.shareLevel = SHARE_LEVEL_BYTELIST;
this.setFrozen(true);
this.hash = strHashCode(runtime);
this.fixHash = runtime.newFixnum(hash);
}

protected FString(Ruby runtime, String string) {
Expand All @@ -1272,6 +1274,7 @@ protected FString(Ruby runtime, String string) {
this.shareLevel = SHARE_LEVEL_BYTELIST;
this.setFrozen(true);
this.hash = strHashCode(runtime);
this.fixHash = runtime.newFixnum(hash);
}

@Override
Expand Down Expand Up @@ -1319,6 +1322,15 @@ public FString dupAsFString(Ruby runtime) {
return this;
}

public RubyFixnum hash(ThreadContext context) {
return fixHash;
}

@Override
public int hashCode() {
return hash;
}

@Override
public long longHashCode() {
return hash;
Expand Down