Retire safe double processing utilities#9021
Merged
Merged
Conversation
This came about when an old version of Java had a CVE and would end up in an endless loop processing a number (numbers?). This was fixed in Java 1.6. Here is a reference to it being fixed: https://www.exploringbinary.com/fpupdater-fixes-the-java-2-2250738585072012e-308-bug/ This should get rid of multiple scans and simplify the overall codepath of converting a string to a double/bigdecimal.
headius
approved these changes
Oct 6, 2025
headius
left a comment
headius
left a comment
Member
There was a problem hiding this comment.
Looks good! Love deleting code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came about when an old version of Java had a CVE and would end up in an endless loop processing a number (numbers?). This was fixed in Java 1.6.
Here is a reference to it being fixed:
https://www.exploringbinary.com/fpupdater-fixes-the-java-2-2250738585072012e-308-bug/
This should get rid of multiple scans and simplify the overall codepath of converting a string to a double/bigdecimal.