Skip to content

Handle warn(foo, uplevel: nil) #9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 1 commit into from
Sep 15, 2025
Merged

Handle warn(foo, uplevel: nil) #9007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/jruby/RubyKernel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1484,7 +1484,7 @@ public static IRubyObject warn(ThreadContext context, IRubyObject recv, IRubyObj
argMessagesLen--;

IRubyObject[] ret = ArgsUtil.extractKeywordArgs(context, (RubyHash) opts, "uplevel", "category");
if (ret[0] != null) {
if (ret[0] != null && !ret[0].isNil()) {
explicitUplevel = true;
uplevel = toInt(context, ret[0]);
if (uplevel < 0) throw argumentError(context, "negative level (" + uplevel + ")");
Expand Down
6 changes: 6 additions & 0 deletions spec/ruby/core/kernel/warn_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,12 @@
ruby_exe(file, options: "-rrubygems", args: "2>&1").should == "#{file}:2: warning: warn-require-warning\n"
end

it "doesn't show the caller when the uplevel is `nil`" do
w = KernelSpecs::WarnInNestedCall.new

-> { w.f4("foo", nil) }.should output(nil, "foo\n")
end

guard -> { Kernel.instance_method(:tap).source_location } do
it "skips <internal: core library methods defined in Ruby" do
file, line = Kernel.instance_method(:tap).source_location
Expand Down
Loading