Backport indy ruby2_keywords ArgumentError fix#9001
Merged
Conversation
Don't clear callInfo for Ruby methods
Member
Author
|
Seems to be another fix made in 10 that needs to be backported. @enebo do you know what change fixed the failing specs here? |
Member
|
@headius I would have to guess that because interp and JIT sometimes call different IRRuntimeHelper methods there is a disparity between the versions. These all appear to involve variable arity so I don't think it involves the JITs fixed arity path. |
headius
force-pushed
the
ruby2_kwargs_indy_fix_9.4
branch
from
96df0a3 to
185d62e
Compare
headius
pushed a commit
that referenced
this pull request
Jul 8, 2026
The backport of kwargs tweaks from 10.x in #9001 (185d62e) dropped the CALL_SPLATS guard present in 10.x kwargsActionJIT. As a result, the JIT specific-arity receive path dups and unflags any ruby2_keywords-flagged hash, even when it is passed as an ordinary positional argument rather than through a splat. CRuby, JRuby 9.4.14.0, and JRuby 10.x pass the same object through with its flag intact. This corrupted Rails ActiveJob argument serialization, which checks Hash.ruby2_keywords_hash? on a hash received as a positional parameter: jobs enqueued with keyword arguments were persisted with _aj_symbol_keys instead of _aj_ruby2_keywords and failed at execution with 'wrong number of arguments'. Restore the CALL_SPLATS guard to match 10.x. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8922.
Fixes #9000.