Skip to content

dup a lot #8716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enebo wants to merge 1 commit into from
Closed

dup a lot #8716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions core/src/main/java/org/jruby/ir/runtime/IRRuntimeHelpers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,7 @@ private static IRubyObject receiverSpecificArityKwargsCommon(ThreadContext conte

// We pass empty kwrest through so kwrest does not try and slurp it up as normal argument.
// This complicates check_arity but empty ** is special case.
RubyHash hash = (RubyHash) last;
RubyHash hash = (RubyHash) last.dup(context);
return hash;
} else if (!isKwarg) {
// This is just an ordinary hash as last argument
Expand Down Expand Up @@ -813,6 +813,8 @@ private static IRubyObject receiveKeywordsWithSplatsNoRestNoKeywords(ThreadConte
clearTrailingHashRuby2Keywords(context, args, hash);
}

args[args.length - 1] = hash.dup(context);

return UNDEFINED;
}

Expand Down Expand Up @@ -840,11 +842,7 @@ private static IRubyObject receiveKeywordsHash(ThreadContext context, IRubyObjec
return hash.dupFast(context);
}

// FIXME: This is a bit gross. a real kwarg callsite if passed to a non-kwarg method but it
// has a rest arg will dup the original kwarg (presumably so you cannot modify the original
// kwarg hash). This should be handled during recv_rest_arg but we no longer have the info so
// it happening here.
if (hasRestArgs) args[args.length - 1] = hash.dup(context);
args[args.length - 1] = hash.dup(context);

// All other situations no-op
return UNDEFINED;
Expand Down