We have many pom.rb files with peculiar code styles, mostly stemming from changing coding conventions over time and improvements in Ruby like the new keyword syntax. There's also unusual indentation and inconsistent use of symbols versus strings and colon-hashes versus hashrockets. This makes maintaining the build scripts annoying and if we start using newer conventions in part of a file it looks inconsistent with the rest of the file.
I propose that we do a sweep for JRuby 10 to clean up Ruby syntax in these files and consistently apply modern Ruby coding conventions.
This will necessarily split the history of these files, but it's a band-aid that needs to be ripped off eventually. Doing this in JRuby 10 makes sense because there will be other large-scale changes for Java 17+ and modularity that will also make forward-merging difficult or impossible.
A partial list of files that should be addressed:
There may be other pom.rb or Mavenfile files that could use similar attention.
Bonus round: wire up an automated linter or code convention auditor to help ensure the files stay clean.
Work should be done on the 9.5-dev branch until we have merged that back to master for JRuby 10.
We have many pom.rb files with peculiar code styles, mostly stemming from changing coding conventions over time and improvements in Ruby like the new keyword syntax. There's also unusual indentation and inconsistent use of symbols versus strings and colon-hashes versus hashrockets. This makes maintaining the build scripts annoying and if we start using newer conventions in part of a file it looks inconsistent with the rest of the file.
I propose that we do a sweep for JRuby 10 to clean up Ruby syntax in these files and consistently apply modern Ruby coding conventions.
This will necessarily split the history of these files, but it's a band-aid that needs to be ripped off eventually. Doing this in JRuby 10 makes sense because there will be other large-scale changes for Java 17+ and modularity that will also make forward-merging difficult or impossible.
A partial list of files that should be addressed:
There may be other pom.rb or Mavenfile files that could use similar attention.
Bonus round: wire up an automated linter or code convention auditor to help ensure the files stay clean.
Work should be done on the
9.5-devbranch until we have merged that back to master for JRuby 10.