allow efficient diffing from the command line (integrated with idahunt)#246
Merged
joxeankoret merged 4 commits intojoxeankoret:masterfrom Dec 15, 2022
Merged
allow efficient diffing from the command line (integrated with idahunt)#246joxeankoret merged 4 commits intojoxeankoret:masterfrom
joxeankoret merged 4 commits intojoxeankoret:masterfrom
Conversation
joxeankoret
reviewed
Dec 14, 2022
joxeankoret
requested changes
Dec 14, 2022
Owner
joxeankoret
left a comment
joxeankoret
left a comment
There was a problem hiding this comment.
Thank you very much for your patches! I have written a review for this PR. I hope it finds you well, my aim is not to annoy or bother you.
added 2 commits
December 14, 2022 13:49
Author
|
I've made additional changes and commented on your comments. Thanks for the feedbacks. |
Author
|
I've made the additional changes based on your feedbacks. If you are happy with them, feel free to merge. |
joxeankoret
approved these changes
Dec 15, 2022
Owner
|
And changes integrated. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example of use for this is in idahunt. See detailed example in https://github.com/nccgroup/idahunt#binary-diffing where it shows how IDA is called and what environment variables are set. We obtain https://github.com/nccgroup/idahunt/blob/main/img/TmRecoverResourceManagerExt.png
The code changes consists in: