Add support for xxhash#38
Merged
joseph-fox merged 1 commit intojoseph-fox:masterfrom Oct 7, 2022
varunkumar:master
Merged
Conversation
joseph-fox
approved these changes
Oct 7, 2022
Owner
|
@varunkumar many thanks for this PR. Are you happy to add a brief note on replacing MD5 with xxh3_128 to the readme? |
Author
|
@joseph-fox Sure. Have you published a new version? Can you please help me with the version? I can add a brief note about the breaking change with that version. |
Owner
|
@varunkumar it would be very helpful if you could add the note before we release the new version, so others will be able to read your updates on pypi. Thank you. |
Author
|
Mind adding hackoctoberfest labels to this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for xxhash, one of the fastest non-cryptographic hashes. It replaces md5 hash function for 128 bits.
Attaching benchmark runs. xxh3_128 is consistently faster than md5. As suggested in this issue, xxh3_128 can be made default in new versions of this module.
hashfn: openssl_md5
hashfn: xxh3_128