Relationship can be added multiple times. This can occur e.g. when a

jodzga · jodzga · commit 67d7eca4084c · 2015-03-20T21:27:30.000-07:00
task is scheduled by a parent and in some other way. Relationship
POTENTIAL_PARENT_OF might be added twice: first when task is being run
by parent but it is already running and second time when parent is
resolved and thus cancelling this task.
diff --git a/src/com/linkedin/parseq/trace/TraceBuilder.java b/src/com/linkedin/parseq/trace/TraceBuilder.java
@@ -67,9 +67,7 @@ public synchronized void addRelationship(final Relationship relationship, final
     addShallowTrace(from);
     addShallowTrace(to);
     final TraceRelationship rel = new TraceRelationship(from.getId(), to.getId(), relationship);
-    if (!_relationships.add(rel)) {
-      throw new IllegalArgumentException("Relationship already exists: " + rel);
-    }
+    _relationships.add(rel);
     increaseRefCount(from.getId());
     increaseRefCount(to.getId());
   }
diff --git a/test/com/linkedin/parseq/trace/TestTraceBuilder.java b/test/com/linkedin/parseq/trace/TestTraceBuilder.java
@@ -18,7 +18,6 @@
 
 import static org.testng.AssertJUnit.assertEquals;
 import static org.testng.AssertJUnit.assertTrue;
-import static org.testng.AssertJUnit.fail;
 
 import org.testng.annotations.Test;
 
@@ -59,14 +58,11 @@ public void testAddRelationshipTwice()
     .setResultType(ResultType.UNFINISHED);
     final TraceBuilder builder = new TraceBuilder(1024);
     builder.addRelationship(Relationship.SUCCESSOR_OF, trace1, trace2);
-    try
-    {
-      builder.addRelationship(Relationship.SUCCESSOR_OF, trace1, trace2);
-      fail("Should have thrown IllegalArgumentException");
-    }
-    catch (IllegalArgumentException e)
-    {
-      // Expected case
-    }
+    builder.addRelationship(Relationship.SUCCESSOR_OF, trace1, trace2);
+    Trace trace = builder.build();
+    assertEquals(trace1.build(), trace.getTraceMap().get(trace1.getId()));
+    assertEquals(trace2.build(), trace.getTraceMap().get(trace2.getId()));
+    assertEquals(1, trace.getRelationships().size());
+    assertTrue(trace.getRelationships().contains(new TraceRelationship(trace1.getId(), trace2.getId(), Relationship.SUCCESSOR_OF)));
   }
 }
