Removed unused Context.afterTask() and old TODOs.

jodzga · jodzga · commit 52ec894840c8 · 2015-03-19T00:21:12.000-07:00
diff --git a/src/com/linkedin/parseq/BaseTask.java b/src/com/linkedin/parseq/BaseTask.java
@@ -502,11 +502,6 @@ public void runSubTask(Task<?> task, Task<?> rootTask) {
       getTraceBuilder().addRelationship(Relationship.POTENTIAL_PARENT_OF, getShallowTraceBuilder(), task.getShallowTraceBuilder());
     }
 
-    @Override
-    public After afterTask(Task<Object> rootTask, Promise<?>... promises) {
-      return new WrappedAfter(_context.afterTask(rootTask, promises));
-    }
-
     @Override
     public TraceBuilder getTraceBuilder() {
       return _context.getTraceBuilder();
diff --git a/src/com/linkedin/parseq/Context.java b/src/com/linkedin/parseq/Context.java
@@ -72,9 +72,6 @@ public interface Context
    */
   After after(Promise<?>... promises);
 
-  //TODO do we really need this???
-  After afterTask(Task<Object> rootTask, Promise<?>... promises);
-
   /**
    * Provides a mechanism for "plugins" to generate data which should be passed in via the context.
    * The intent is that the "plugin" registers engine specific data it needed via the engine builder.
diff --git a/src/com/linkedin/parseq/FusionTask.java b/src/com/linkedin/parseq/FusionTask.java
@@ -22,7 +22,6 @@
 /**
  * TODO optimize flatmap - can it be run without rescheduling?
  * TODO fix flatmap trace - possibly by reimplementing flatten
- * TODO fix withtimeout - it's synchronous
  *
  *
  * @author jodzga
diff --git a/src/com/linkedin/parseq/internal/ContextImpl.java b/src/com/linkedin/parseq/internal/ContextImpl.java
@@ -166,15 +166,6 @@ public void runSubTask(Task<?> task, Task<?> rootTask) {
     }
   }
 
-  /**
-   * TODO
-   * this is a way in from other threads to schedule task on this context
-   *
-   * Streaming idea: remember last task and once there is next task available call after to sequence
-   * tasks.
-   *
-   * for parallel we might need simply runSubTask(right away)
-   */
   @Override
   public After after(final Promise<?>... promises)
   {
@@ -235,25 +226,6 @@ public void onResolved(Promise<Object> resolvedPromise)
     };
   }
 
-  @Override
-  public After afterTask(Task<Object> rootTask, Promise<?>... promises) {
-    // check reference equality to make sure model is consistent i.e.
-    // subtasks have same parent
-    if (rootTask != _task)  {
-      throw new RuntimeException("Context method invoked associated with wrong task");
-    }
-    final Task<?> temp = _inTask.get();
-    _inTask.set(_task);
-    try
-    {
-      return after(promises);
-    }
-    finally
-    {
-      _inTask.set(temp);
-    }
-  }
-
   @Override
   public boolean cancel(Exception reason)
   {
diff --git a/test/com/linkedin/parseq/TestTaskStates.java b/test/com/linkedin/parseq/TestTaskStates.java
@@ -440,11 +440,6 @@ public void runSubTask(Task<?> task, Task<?> rootTask) {
       throw new UnsupportedOperationException();
     }
 
-    @Override
-    public After afterTask(Task<Object> rootTask, Promise<?>... promises) {
-      throw new UnsupportedOperationException();
-    }
-
     @Override
     public TraceBuilder getTraceBuilder() {
       return new TraceBuilder(1024);

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@`
`22`	`22`	`/**`
`23`	`23`	`* TODO optimize flatmap - can it be run without rescheduling?`
`24`	`24`	`* TODO fix flatmap trace - possibly by reimplementing flatten`
`25`		`- * TODO fix withtimeout - it's synchronous`
`26`	`25`	`*`
`27`	`26`	`*`
`28`	`27`	`* @author jodzga`