-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[RFC] Major breaking changes in the upcoming release #974
Copy link
Copy link
Closed
Labels
api-reviewCategorizes an issue or PR as actively needing an API review.Categorizes an issue or PR as actively needing an API review.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.release-note-action-requiredDenotes a PR that introduces potentially breaking changes that require user action.Denotes a PR that introduces potentially breaking changes that require user action.
Metadata
Metadata
Assignees
Labels
api-reviewCategorizes an issue or PR as actively needing an API review.Categorizes an issue or PR as actively needing an API review.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.release-note-action-requiredDenotes a PR that introduces potentially breaking changes that require user action.Denotes a PR that introduces potentially breaking changes that require user action.
Hi Kubernetes Python client developers, this is a request for comment issue. Please leave comments if you have any opinion/suggestion. Thanks!
What happened:
A majority of the code base is generated code. This repo is switching from using swagger-codegen to using openapi-generator. For more backgrounds:
Major breaking changes were detected when we released 11.0.0a1 with openapi-generator:
The breaking changes are:
kubernetes.client.apispackage is renamed tokubernetes.client.apikubernetespackage code now uses absolute import instead of relative importswagger_typesattribute in all models is renamed toopenapi_typesthe major breaking changes come from swagger-api/swagger-codegen#6839 (comment), which is also in latest swagger-codegen. This repo didn't have these changes because we were depending on a old version of swagger-codegen.
What versions are affected?:
8.0.x,9.0.x,10.0.xversions are not affected11.0.0a1(corresponding to Kubernetes 1.15) is the only version that's affected currently11.0.0b1and future releases (corresponding to Kubernetes 1.15, 1.16+) will be affected.Impact and fix:
kubernetes.client.apismust change the import tokubernetes.client.apiwhen upgrading to 11.0.0b1+, to avoid import error.kubernetespackage locally may experience unexpected import error. Clients should installkubernetespackage properly following the instructions in the Readme or the release page.