Proxy from multiple sources with priority. Custom Local Identifier fix#30
Merged
francisf merged 6 commits intojenkinsci:masterfrom Dec 28, 2020
Merged
Conversation
1. PluginsTracker static to instance specific client to prevent overriding 2. Credentials check via proxy 3. pom update for automate-client-java for optional proxy-auth params
rchougule
changed the title
harshitvasu
reviewed
Dec 18, 2020
harshitvasu
reviewed
Dec 18, 2020
harshitvasu
reviewed
Dec 18, 2020
harshitvasu
approved these changes
Dec 18, 2020
francisf
approved these changes
Dec 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://browserstack.atlassian.net/browse/ACE-1568
Changes:
a.
https_proxyandhttp_proxyset viawithEnvin Pipeline scriptb.
https_proxyandhttp_proxyset in System level, retrieved usingSystem.getenvc. Jenkins Proxy configuration
d. JAR arguments, i.e.
https.proxyHost, https.proxyPort, https.proxyUser, https.proxyPasswordRelated PR for the included changes: browserstack/automate-client-java#8 - To make proxy auth params non-mandatory while reaching out to BrowserStack via the plugin.