Skip to content

BigInt#120

Merged
mahdyar merged 3 commits intojavascript-tutorial:masterfrom
amirhshahbazi:BigInt
May 6, 2021
Merged

BigInt#120
mahdyar merged 3 commits intojavascript-tutorial:masterfrom
amirhshahbazi:BigInt

Conversation

@amirhshahbazi
Copy link
Contributor

Translated the BigInt page.

@javascript-translate-bot

Error: the article already has PR number in the Progress Issue #1, it's 117 ⁉️

Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to make a new pull request for any changes you make. you can add more commits by pushing to the BigInt branch on your fork.
In addition to that, please read the Translation Tips:

Please keep line breaks and paragraphs "as is": don't add new lines and don't remove existing ones. Makes it easy to merge future changes from the English version into the translation.

You've removed the newline on line 8, please add it back.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@amirhshahbazi
Copy link
Contributor Author

Thanks for the review, @mahdyar
/done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Math operators means عملگرهای ریاضی, not عملیات ریاضی.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put 5/2 between backticks as it was.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to translate Error here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed if needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

مقایسه‌ای would be a better translation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no ابتدا in the text, don't add your own words. Also, you missed so.
پس باید از...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering means در نظر گرفتن.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@amirhshahbazi
Copy link
Contributor Author

Thanks,
/done

Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @amirhshahbazi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments