Skip to content

Comparisons#101

Merged
mahdyar merged 7 commits intojavascript-tutorial:masterfrom
emadpoursina:master
Mar 30, 2021
Merged

Comparisons#101
mahdyar merged 7 commits intojavascript-tutorial:masterfrom
emadpoursina:master

Conversation

@emadpoursina
Copy link
Contributor

Translation is done. Please review and commit if anything is wrong.

Translation is done. Please review and commit if anything is wrong.
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @emadpoursina,
First, you should claim the article in #1.
Also, read the For New Translators section there (#1):

The pull request title should be same as the article, e.g. An Introduction to JavaScript (just like comment)

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@emadpoursina emadpoursina changed the title Translate aticle.md Comparisons Mar 28, 2021
@emadpoursina
Copy link
Contributor Author

emadpoursina commented Mar 28, 2021

/done

Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a folder which contains the tasks and solutions that should also be translated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

عملگرهای مقایسه‌ای زیادی را از ریاضیات می‌شناسیم. would be a better translation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

یک علامت مقایسه برابری معمولی

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strict, not strings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

یک رشتهٔ خالی

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

خلاصه is what we used in other articles, so it'd be better if you use the same.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

اجتناب از مشکلات

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

نیفتیم

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

; is not needed, use ..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

زمانی که این قانون‌ها را اعمال می‌کنیم را ببینیم

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of
چند اتفاق با مزه و جالب که زمانی که,
چند اتفاق با مزه و جالب زمانی که would be a better translation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

چند اتفاق بامزه و جالب که با اعمال این قانون ها می افتند را ببینیم.‍

I think is better.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@emadpoursina
Copy link
Contributor Author

/done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

بعضی از دلایل: would be a better translation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata shouldn't be translated. [+]

Comment on lines 15 to 21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove dots from the end of sentences. e.g:
برابری سختگیرانه برای دو داده از دو نوع متفاوت <- برابری سختگیرانه برای دو داده از دو نوع متفاوت.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in Persian, we don't have ,, using ، would be a better idea.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@emadpoursina
Copy link
Contributor Author

/done

@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments