Issue http://java.net/jira/browse/GLASSFISH-16221

Kin Man Chung · Kin Man Chung · commit 454d89f39784 · 2011-03-23T00:26:48.000Z
TldScanner leaves jar files opened, causing undeploy to fail in Windows.
  

svn path=/trunk/; revision=1375
diff --git a/impl/src/main/java/org/apache/jasper/runtime/TldScanner.java b/impl/src/main/java/org/apache/jasper/runtime/TldScanner.java
@@ -426,6 +426,11 @@ private void scanJar(JarURLConnection conn, List<String> tldNames,
 
         // Optimize for most common cases: jars known to NOT have tlds
         if (tldInfos != null && tldInfos.length == 0) {
+            try {
+                conn.getJarFile().close();
+            } catch (IOException ex) {
+                //ignored
+            }
             return;
         }
 
@@ -434,7 +439,6 @@ private void scanJar(JarURLConnection conn, List<String> tldNames,
             JarFile jarFile = null;
             ArrayList<TldInfo> tldInfoA = new ArrayList<TldInfo>();
             try {
-                conn.setUseCaches(false);
                 jarFile = conn.getJarFile();
                 if (tldNames != null) {
                     for (String tldName : tldNames) {
@@ -681,6 +685,7 @@ private void scanJars() throws Exception {
                         }
                     }
                     if (jconn != null) {
+                        jconn.setUseCaches(false);
                         if (isLocal) {
                             // For local jars, collect the jar files in the
                             // Manifest Class-Path, to be scanned later.
@@ -700,6 +705,7 @@ private void scanJars() throws Exception {
                             URL jarURL = new URL("jar:" + jar + "!/");
                             JarURLConnection jconn =
                                     (JarURLConnection) jarURL.openConnection();
+                            jconn.setUseCaches(false);
                             if (addManifestClassPath(extraJars,newJars,jconn)){
                                 scanJar(jconn, null, true);
                             }
