BUG#14146388 : MOVE ALL CRYPTO-RELATED FILES UNDER MYSYS_SSL

Tor Didriksen · Tor Didriksen · commit 2686d527eff0 · 2012-08-07T07:14:58.000+02:00
Cleanup, and comment on the -fvisibility=hidden flag.
diff --git a/cmake/libutils.cmake b/cmake/libutils.cmake
@@ -286,6 +286,8 @@ FUNCTION(GET_DEPENDEND_OS_LIBS target result)
   SET(${result} ${ret} PARENT_SCOPE)
 ENDFUNCTION()
 
+# We try to hide the symbols in yassl/zlib to avoid name clashes with
+# other libraries like openssl.
 FUNCTION(RESTRICT_SYMBOL_EXPORTS target)
   IF(CMAKE_COMPILER_IS_GNUCXX AND UNIX)
     SET(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -Werror")
diff --git a/libmysql/CMakeLists.txt b/libmysql/CMakeLists.txt
@@ -143,21 +143,12 @@ SET(CLIENT_SOURCES
   ../sql-common/client.c 
   ../sql-common/my_time.c 
   ../sql-common/client_plugin.c 
-  ../sql-common/crypt_genhash_impl.cc
   ../sql-common/client_authentication.cc
   ../sql/net_serv.cc
   ../sql-common/pack.c 
   ../sql/password.c
 )
 
-# We do RESTRICT_SYMBOL_EXPORTS(yassl) elsewhere.
-# In order to get correct symbol visibility, md5.cc and sha1.cc
-# must be compiled with "-fvisibility=hidden"
-IF(HAVE_VISIBILITY_HIDDEN)
-  SET_SOURCE_FILES_PROPERTIES(../sql-common/crypt_genhash_impl.cc
-    PROPERTIES COMPILE_FLAGS "-fvisibility=hidden")
-ENDIF()
-
 ADD_CONVENIENCE_LIBRARY(clientlib ${CLIENT_SOURCES})
 DTRACE_INSTRUMENT(clientlib)
 ADD_DEPENDENCIES(clientlib GenError)
diff --git a/libmysqld/CMakeLists.txt b/libmysqld/CMakeLists.txt
@@ -42,16 +42,6 @@ FOREACH(file ${SQL_EXPORTED_SOURCES})
   LIST(APPEND IMPORTED_SOURCES "../sql/${file}")
 ENDFOREACH()
 
-# We do RESTRICT_SYMBOL_EXPORTS(yassl) elsewhere.
-# In order to get correct symbol visibility, md5.cc and sha1.cc
-# must be compiled with "-fvisibility=hidden"
-IF(HAVE_VISIBILITY_HIDDEN)
-  SET_SOURCE_FILES_PROPERTIES(../sql/md5.cc
-    PROPERTIES COMPILE_FLAGS "-fvisibility=hidden")
-  SET_SOURCE_FILES_PROPERTIES(../sql/sha1.cc
-    PROPERTIES COMPILE_FLAGS "-fvisibility=hidden")
-ENDIF()
-
 SET(SQL_EMBEDDED_SOURCES
   emb_qcache.cc
   lib_sql.cc 
diff --git a/mysys_ssl/CMakeLists.txt b/mysys_ssl/CMakeLists.txt
@@ -22,20 +22,20 @@ ADD_DEFINITIONS(${SSL_DEFINES})
 ENDIF()
 
 # We do RESTRICT_SYMBOL_EXPORTS(yassl) elsewhere.
-# In order to get correct symbol visibility, my_aes.cc
+# In order to get correct symbol visibility, these files
 # must be compiled with "-fvisibility=hidden"
 IF(HAVE_VISIBILITY_HIDDEN)
-  SET_SOURCE_FILES_PROPERTIES(my_aes.cc
-    PROPERTIES COMPILE_FLAGS "-fvisibility=hidden")
-  SET_SOURCE_FILES_PROPERTIES(my_md5.cc
-    PROPERTIES COMPILE_FLAGS "-fvisibility=hidden")
-  SET_SOURCE_FILES_PROPERTIES(my_sha1.cc
-    PROPERTIES COMPILE_FLAGS "-fvisibility=hidden")
-  SET_SOURCE_FILES_PROPERTIES(my_sha2.cc
+  SET_SOURCE_FILES_PROPERTIES(
+    crypt_genhash_impl.cc
+    my_aes.cc
+    my_md5.cc
+    my_sha1.cc
+    my_sha2.cc
     PROPERTIES COMPILE_FLAGS "-fvisibility=hidden")
 ENDIF()
 
 SET(MYSYS_SSL_SOURCES
+    crypt_genhash_impl.cc
     my_default.cc
     my_getopt.cc
     my_aes.cc
diff --git a/mysys_ssl/crypt_genhash_impl.cc b/mysys_ssl/crypt_genhash_impl.cc
diff --git a/sql/CMakeLists.txt b/sql/CMakeLists.txt
@@ -84,7 +84,6 @@ SET(SQL_SHARED_SOURCES
   parse_file.cc
   partition_info.cc
   password.c
-  ../sql-common/crypt_genhash_impl.cc
   procedure.cc 
   protocol.cc
   records.cc
